[Webkit-unassigned] [Bug 159224] Use a regex to check if a test step is for JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159224

--- Comment #12 from Sri Vijayaraghavan <svijayaraghavan at apple.com> ---
(In reply to comment #10)
> Comment on attachment 282286 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282286&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:254
> > +            else if (/(?=.*test)(?=.*jsc)/.test(step.name) === true)
> 
> WebKit coding style calls for no comparison to true, should be just if
> (/(?=.*test)(?=.*jsc)/.test(step.name))
> 
> Sorry for missing it the first time around (I blame Geoff of course).

Sorry about that, just resubmitted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/c454e51a/attachment.html>