<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use a regex to check if a test step is for JavaScriptCore"
href="https://bugs.webkit.org/show_bug.cgi?id=159224#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use a regex to check if a test step is for JavaScriptCore"
href="https://bugs.webkit.org/show_bug.cgi?id=159224">bug 159224</a>
from <span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159224#c10">comment #10</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=282286&action=diff" name="attach_282286" title="Patch">attachment 282286</a> <a href="attachment.cgi?id=282286&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282286&action=review">https://bugs.webkit.org/attachment.cgi?id=282286&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:254
> > + else if (/(?=.*test)(?=.*jsc)/.test(step.name) === true)
>
> WebKit coding style calls for no comparison to true, should be just if
> (/(?=.*test)(?=.*jsc)/.test(step.name))
>
> Sorry for missing it the first time around (I blame Geoff of course).</span >
Sorry about that, just resubmitted.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>