[Webkit-unassigned] [Bug 159224] Use a regex to check if a test step is for JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159224

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 282279
  --> https://bugs.webkit.org/attachment.cgi?id=282279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282279&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:112
> -                    } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(mostRecentFinishedIteration.failedTestSteps[0].name) >= 0) {
> +                    } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && /jsc/.test(mostRecentFinishedIteration.failedTestSteps[0].name) === true) {

Would it make sense to make sure that "test" is in the name too? That would decrease the chances of something like "build-jsc" or "configure-jsc-dependencies" to confuse the logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/2cec5551/attachment.html>