[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 11:44:49 PDT 2016


--- Comment #93 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 281613
  --> https://bugs.webkit.org/attachment.cgi?id=281613

View in context: https://bugs.webkit.org/attachment.cgi?id=281613&action=review

Looks good! I just have a couple of comments/questions.

> Source/JavaScriptCore/ChangeLog:12
> +        offset of a object to call a getter function and get_by_id_proto_custo

typo: git_by_id_proto_custom

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1299
> +   bineq 0, dest, .loadEncodedThisValueDone

Does this get assembled to: 
test: dest, dest 
jz: .loadEncodedThisValueDone
? If not, we should probably try to figure out how to make that happen.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/90992dbb/attachment-0001.html>

More information about the webkit-unassigned mailing list