<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c93">Comment # 93</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281613&action=diff" name="attach_281613" title="Patch">attachment 281613</a> <a href="attachment.cgi?id=281613&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281613&action=review">https://bugs.webkit.org/attachment.cgi?id=281613&action=review</a>
Looks good! I just have a couple of comments/questions.
<span class="quote">> Source/JavaScriptCore/ChangeLog:12
> + offset of a object to call a getter function and get_by_id_proto_custo</span >
typo: git_by_id_proto_custom
<span class="quote">> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1299
> + bineq 0, dest, .loadEncodedThisValueDone</span >
Does this get assembled to:
test: dest, dest
jz: .loadEncodedThisValueDone
? If not, we should probably try to figure out how to make that happen.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>