[Webkit-unassigned] [Bug 159089] REGRESSION(r198782, r201043): [image-decoders] Flickering with some animated gif

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159089

--- Comment #3 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 281971
  --> https://bugs.webkit.org/attachment.cgi?id=281971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281971&action=review

> Source/WebCore/platform/image-decoders/ImageDecoder.cpp:319
> +    if (!buffer || buffer->status() == ImageFrame::FrameEmpty || size().isEmpty())

I don't like this kind of dependency and implicit hidden calculation. How do I know or remember that to get the size of image in the ImageDecoder I have to call frameBufferAtIndex() first? Can't we fix this by changing the base class function ImageDecoder::setSize() to be like this:

virtual IntSize size() { return frameBufferAtIndex(0) ? m_size : IntSize(); }

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/9be29d55/attachment.html>