<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r198782, r201043): [image-decoders] Flickering with some animated gif"
href="https://bugs.webkit.org/show_bug.cgi?id=159089#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r198782, r201043): [image-decoders] Flickering with some animated gif"
href="https://bugs.webkit.org/show_bug.cgi?id=159089">bug 159089</a>
from <span class="vcard"><a class="email" href="mailto:sabouhallawa@apple.com" title="Said Abou-Hallawa <sabouhallawa@apple.com>"> <span class="fn">Said Abou-Hallawa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281971&action=diff" name="attach_281971" title="Patch">attachment 281971</a> <a href="attachment.cgi?id=281971&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281971&action=review">https://bugs.webkit.org/attachment.cgi?id=281971&action=review</a>
<span class="quote">> Source/WebCore/platform/image-decoders/ImageDecoder.cpp:319
> + if (!buffer || buffer->status() == ImageFrame::FrameEmpty || size().isEmpty())</span >
I don't like this kind of dependency and implicit hidden calculation. How do I know or remember that to get the size of image in the ImageDecoder I have to call frameBufferAtIndex() first? Can't we fix this by changing the base class function ImageDecoder::setSize() to be like this:
virtual IntSize size() { return frameBufferAtIndex(0) ? m_size : IntSize(); }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>