[Webkit-unassigned] [Bug 159145] REGRESSION(r202337) [WebRTC] Crash when loading html5test.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159145

--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 282224
  --> https://bugs.webkit.org/attachment.cgi?id=282224
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282224&action=review

> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:56
> +class NullMediaEndpoint : public MediaEndpoint {

I think EmptyMediaEndpoint would be a better name.

> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:80
> +    return std::unique_ptr<MediaEndpoint>(new NullMediaEndpoint(client));

make_unique.  Also, this function is not necessary.  Just use std::make_unique instead of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/348edc11/attachment.html>