[Webkit-unassigned] [Bug 159067] prepare-ChangeLog lists methods that were not modified when deleting other methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159067

--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to comment #1)
> Also, this issue appears to only happen on Subversion repositories.  When I
> applied the patch in Bug 158819 (Attachment #281464 [details]) on a git-svn
> repository at r202384, then ran prepare-ChangeLog, I didn't get the
> extraneous functions listed in the commit log.

I have an untested hypothesis:

What could be happening is that when prepare-ChangeLog tries to grab the "pristine" (unmodified) source to determine the line ranges for functions (to compare to the local modified copy), it's actually grabbing the trunk (-rHEAD) from the svn server, where line numbers have shifted since the local working copy's revision, and that causes prepare-ChangeLog to list methods that weren't actually changed.

If this is the case, then we just need to check how prepare-ChangeLog is grating the pristine source version, and make sure it's grabbing the pristine source relative to the local working copy (not to trunk on the svn server).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160624/ab367921/attachment.html>