<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog lists methods that were not modified when deleting other methods"
href="https://bugs.webkit.org/show_bug.cgi?id=159067#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog lists methods that were not modified when deleting other methods"
href="https://bugs.webkit.org/show_bug.cgi?id=159067">bug 159067</a>
from <span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159067#c1">comment #1</a>)
<span class="quote">> Also, this issue appears to only happen on Subversion repositories. When I
> applied the patch in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Remove unused didCancelAuthenticationChallenge"
href="show_bug.cgi?id=158819">Bug 158819</a> (<span class=""><a href="attachment.cgi?id=281464&action=diff" name="attach_281464" title="Patch">Attachment #281464</a> <a href="attachment.cgi?id=281464&action=edit" title="Patch">[details]</a></span>) on a git-svn
> repository at r202384, then ran prepare-ChangeLog, I didn't get the
> extraneous functions listed in the commit log.</span >
I have an untested hypothesis:
What could be happening is that when prepare-ChangeLog tries to grab the "pristine" (unmodified) source to determine the line ranges for functions (to compare to the local modified copy), it's actually grabbing the trunk (-rHEAD) from the svn server, where line numbers have shifted since the local working copy's revision, and that causes prepare-ChangeLog to list methods that weren't actually changed.
If this is the case, then we just need to check how prepare-ChangeLog is grating the pristine source version, and make sure it's grabbing the pristine source relative to the local working copy (not to trunk on the svn server).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>