[Webkit-unassigned] [Bug 159024] [Soup] Clean up SocketStreamHandle soup implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159024

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281842|review?                     |review+
              Flags|                            |

--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 281842
  --> https://bugs.webkit.org/attachment.cgi?id=281842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281842&action=review

> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:223
> +    g_source_set_callback(m_writeReadySource.get(), reinterpret_cast<GSourceFunc>(writeReadyCallback), this, [](gpointer handle) {
> +        static_cast<SocketStreamHandle*>(handle)->deref();
> +    });

IMO the lambda would be more readable if its header was also placed on its own line, and all three lines being indented by 4 spaces compared to the start of this expression.

The rest of this patch adopts the leaked pointer into a RefPtr<> wrapper, this should do the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/06bb2423/attachment.html>