[Webkit-unassigned] [Bug 158993] imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html is a flaky timeout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158993

--- Comment #7 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > But it's an imported test, so we can't really modify it.
> > 
> > Indeed, the ideal would be not to change it.
> 
> Ideally, if it is getting imported once, we should be able to reimport the
> tests again and again. Tests should be able to improve, like source code.
> 
> Is there a git repository, like for W3C wpt/css test suites?
> If so, WebKit changes should be contributed to that repo.
> 
> For WPT tests, when I need to change a test, I add a comment like: //WEBKIT
> change:... to the WebKit test.
> 
> I then upstream the changes to W3C repo.
> When I reimport the tests from W3C repo (once a while), the only remaining
> change is the removal of the // WEBKIT comment.

Yes, the repo is at https://github.com/MathML/MathMLinHTML5-tests for now and indeed I agree with you that it is great if browser vendors contribute there when there are mistakes in the test. The change discussed here is actually a workaround for font loading bug in WebKit (bug 158884). So my point is that it is fine to do a small hack so that we can run the actual MathML test but ideally we should not deviate too much from upstream and even less contribute back such hacks ;-). The best remains to fix bug 158884, so that the test passes when we open http://tests.mathml-association.org/mathml/presentation-markup/scripts/subsup-parameters-1.html in WebKit :-)

BTW, this test also has another change to disable the SuperscriptShiftUpCramped part until bug 156401 is fixed.

Finally, the path to the fonts has also been modified to be executed... That also seems to be what is done in some tests for LayoutTests/imported/w3c/canvas when loading the CanvasTest.ttf font...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160622/d62199d1/attachment.html>