[Webkit-unassigned] [Bug 155750] [GTK] Add kinetic scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155750

--- Comment #25 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #24)
> Comment on attachment 281354 [details]
> [GTK] Add kinetic scrolling
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281354&action=review
> 
> >> Source/WebKit2/Shared/NativeWebWheelEvent.h:55
> >> +    NativeWebWheelEvent(GdkEvent*, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase);
> > 
> > Maybe instead of adding a new constructor we could add the phase parameters with default values
> 
> I am not sure this would work as we need to pass the phase/momentumPhase
> when creating the events from GestureController. I even added a fix in my
> patch to make this work fine with gtk<3.20 (is_stop issue when copying).

And what is the problem? I'm proposing to have a single constructor with the parameters having default values, but you can still call it with other values

> >> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:165
> >> +WebWheelEvent WebEventFactory::createWebWheelEvent(const GdkEvent* event, WebWheelEvent::Phase phase, WebWheelEvent::Phase momentumPhase)
> > 
> > Here we could probably also keep a single method just with default values for the phases.
> 
> Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160621/5abf32d7/attachment-0001.html>