<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add kinetic scrolling"
href="https://bugs.webkit.org/show_bug.cgi?id=155750#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add kinetic scrolling"
href="https://bugs.webkit.org/show_bug.cgi?id=155750">bug 155750</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=155750#c24">comment #24</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=281354&action=diff" name="attach_281354" title="[GTK] Add kinetic scrolling">attachment 281354</a> <a href="attachment.cgi?id=281354&action=edit" title="[GTK] Add kinetic scrolling">[details]</a></span>
> [GTK] Add kinetic scrolling
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281354&action=review">https://bugs.webkit.org/attachment.cgi?id=281354&action=review</a>
>
> >> Source/WebKit2/Shared/NativeWebWheelEvent.h:55
> >> + NativeWebWheelEvent(GdkEvent*, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase);
> >
> > Maybe instead of adding a new constructor we could add the phase parameters with default values
>
> I am not sure this would work as we need to pass the phase/momentumPhase
> when creating the events from GestureController. I even added a fix in my
> patch to make this work fine with gtk<3.20 (is_stop issue when copying).</span >
And what is the problem? I'm proposing to have a single constructor with the parameters having default values, but you can still call it with other values
<span class="quote">> >> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:165
> >> +WebWheelEvent WebEventFactory::createWebWheelEvent(const GdkEvent* event, WebWheelEvent::Phase phase, WebWheelEvent::Phase momentumPhase)
> >
> > Here we could probably also keep a single method just with default values for the phases.
>
> Ditto.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>