[Webkit-unassigned] [Bug 158985] WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158985

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281737|review?                     |review+
              Flags|                            |

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 281737
  --> https://bugs.webkit.org/attachment.cgi?id=281737
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281737&action=review

> LayoutTests/ChangeLog:15
> +        * fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
> +        * fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.
> +        Verify that a negotiationneeded event is fired when not all local media can be included in
> +        an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)
> +        * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
> +        * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

Don't we also need a test for a stream track entering an ended state? A bug for adding that test is fine if you don't want to do it in this patch.

Are there any other operations that should generate a 'negotiationneeded' event?

> LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html:10
> +            description("Test that a negotiationneeded event is fired when all local media can't be included in an answer");

Nit: "when all local media can't be included" -> "when not all local media can be included"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160621/247b4f20/attachment.html>