<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection"
href="https://bugs.webkit.org/show_bug.cgi?id=158985">bug 158985</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #281737 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection"
href="https://bugs.webkit.org/show_bug.cgi?id=158985#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection"
href="https://bugs.webkit.org/show_bug.cgi?id=158985">bug 158985</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281737&action=diff" name="attach_281737" title="Proposed patch">attachment 281737</a> <a href="attachment.cgi?id=281737&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281737&action=review">https://bugs.webkit.org/attachment.cgi?id=281737&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:15
> + * fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
> + * fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.
> + Verify that a negotiationneeded event is fired when not all local media can be included in
> + an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)
> + * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
> + * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:</span >
Don't we also need a test for a stream track entering an ended state? A bug for adding that test is fine if you don't want to do it in this patch.
Are there any other operations that should generate a 'negotiationneeded' event?
<span class="quote">> LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html:10
> + description("Test that a negotiationneeded event is fired when all local media can't be included in an answer");</span >
Nit: "when all local media can't be included" -> "when not all local media can be included"</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>