[Webkit-unassigned] [Bug 90734] [GStreamer] usec rounding is wrong during accurate seeking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90734

--- Comment #26 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #24)
> Comment on attachment 238352 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=238352&action=review
> 
> The code changes in this patch look fine, but I don't understand the test.
> 
> > LayoutTests/media/video-frame-accurate-seek.html:8
> > +        <p>Test that setting currentTime is frame-accurate. Four videos below should be showing up, The first three at frames 12, 13, and 14. The last video should display at 6.0272 seconds.</p>
> 
> The -> the
> 
> > LayoutTests/platform/gtk/media/video-frame-accurate-seek-expected.txt:9
> > +          text run at (0,17) width 356: "and 14. The last video should display at 6.0272 seconds."
> 
> It seems like something is wrong with this test. The expected result for the
> first three videos shows 12, 13, and 15, but the test says it's expected to
> show 12, 13, and 14. 

This now works as expected \o/

> The last video displays 6.01 seconds, not 6.0272 or
> 6.03.
> 

That's because 6.01 means (6 * 25) + 1 frames = 151. And not 0.01 seconds.

So we do a seek to 6.0272 seconds which means 6 seconds and one half-frame (0.02 = 1/50) but the video is at 25fps so the demuxer choses instead to jump to the next full frame, if I understand correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160621/0d6be255/attachment.html>