<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] usec rounding is wrong during accurate seeking"
href="https://bugs.webkit.org/show_bug.cgi?id=90734#c26">Comment # 26</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] usec rounding is wrong during accurate seeking"
href="https://bugs.webkit.org/show_bug.cgi?id=90734">bug 90734</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=90734#c24">comment #24</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=238352&action=diff" name="attach_238352" title="Patch">attachment 238352</a> <a href="attachment.cgi?id=238352&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=238352&action=review">https://bugs.webkit.org/attachment.cgi?id=238352&action=review</a>
>
> The code changes in this patch look fine, but I don't understand the test.
>
> > LayoutTests/media/video-frame-accurate-seek.html:8
> > + <p>Test that setting currentTime is frame-accurate. Four videos below should be showing up, The first three at frames 12, 13, and 14. The last video should display at 6.0272 seconds.</p>
>
> The -> the
>
> > LayoutTests/platform/gtk/media/video-frame-accurate-seek-expected.txt:9
> > + text run at (0,17) width 356: "and 14. The last video should display at 6.0272 seconds."
>
> It seems like something is wrong with this test. The expected result for the
> first three videos shows 12, 13, and 15, but the test says it's expected to
> show 12, 13, and 14. </span >
This now works as expected \o/
<span class="quote">> The last video displays 6.01 seconds, not 6.0272 or
> 6.03.
> </span >
That's because 6.01 means (6 * 25) + 1 frames = 151. And not 0.01 seconds.
So we do a seek to 6.0272 seconds which means 6 seconds and one half-frame (0.02 = 1/50) but the video is at 25fps so the demuxer choses instead to jump to the next full frame, if I understand correctly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>