[Webkit-unassigned] [Bug 148524] [GStreamer] video orientation support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148524

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 281565
  --> https://bugs.webkit.org/attachment.cgi?id=281565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281565&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2003
> +        // the image-orientation tag

Missing full stop

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2004
> +        GstElement* videoFlip = gst_element_factory_make("videoflip", 0);

nullptr :)

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:294
> +    // When using accelerated compositing, if the video is tagged as rotated 90 or 270 degrees, swap width and height

Missing full stop

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:711
> +    switch (m_videoSourceRotation) {

The switch seems useful only when USE(TEXTURE_MAPPER_GL) is on. So maybe use a single ifdef englobing the switch ?

> LayoutTests/media/video-orientation-expected.txt:18
> +EXPECTED (video.videoWidth == '352') OK
> +EXPECTED (video.videoHeight == '288') OK

This doesn't match with the rotation-90.mp4 it seems?

> LayoutTests/media/video-orientation-expected.txt:32
> +EXPECTED (video.videoWidth == '352') OK
> +EXPECTED (video.videoHeight == '288') OK

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160620/53956c3a/attachment.html>