<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] video orientation support"
href="https://bugs.webkit.org/show_bug.cgi?id=148524#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] video orientation support"
href="https://bugs.webkit.org/show_bug.cgi?id=148524">bug 148524</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281565&action=diff" name="attach_281565" title="Patch">attachment 281565</a> <a href="attachment.cgi?id=281565&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281565&action=review">https://bugs.webkit.org/attachment.cgi?id=281565&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2003
> + // the image-orientation tag</span >
Missing full stop
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2004
> + GstElement* videoFlip = gst_element_factory_make("videoflip", 0);</span >
nullptr :)
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:294
> + // When using accelerated compositing, if the video is tagged as rotated 90 or 270 degrees, swap width and height</span >
Missing full stop
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:711
> + switch (m_videoSourceRotation) {</span >
The switch seems useful only when USE(TEXTURE_MAPPER_GL) is on. So maybe use a single ifdef englobing the switch ?
<span class="quote">> LayoutTests/media/video-orientation-expected.txt:18
> +EXPECTED (video.videoWidth == '352') OK
> +EXPECTED (video.videoHeight == '288') OK</span >
This doesn't match with the rotation-90.mp4 it seems?
<span class="quote">> LayoutTests/media/video-orientation-expected.txt:32
> +EXPECTED (video.videoWidth == '352') OK
> +EXPECTED (video.videoHeight == '288') OK</span >
Ditto</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>