[Webkit-unassigned] [Bug 158900] Updating class name of a shadow host does not update the style applied by :host()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158900

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281623|review?                     |review+
              Flags|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 281623
  --> https://bugs.webkit.org/attachment.cgi?id=281623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281623&action=review

> Source/WebCore/style/AttributeChangeInvalidation.cpp:38
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, bool isHTML, const QualifiedName& attributeName)

Can shadowRoot be const?

> Source/WebCore/style/ClassChangeInvalidation.cpp:88
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, AtomicStringImpl* changedClass)

const shadowRoot?

> Source/WebCore/style/IdChangeInvalidation.cpp:44
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, const AtomicString& changedId)
> +{
> +    auto& shadowRuleSets = shadowRoot.styleResolver().ruleSets();
> +    if (shadowRuleSets.authorStyle()->hostPseudoClassRules().isEmpty())
> +        return false;
> +
> +    return shadowRuleSets.features().idsInRules.contains(changedId.impl());
> +}

Can this function that's almost repeated 3 times be shared?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160620/a64da66d/attachment-0001.html>