<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Updating class name of a shadow host does not update the style applied by :host()"
href="https://bugs.webkit.org/show_bug.cgi?id=158900">bug 158900</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #281623 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Updating class name of a shadow host does not update the style applied by :host()"
href="https://bugs.webkit.org/show_bug.cgi?id=158900#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Updating class name of a shadow host does not update the style applied by :host()"
href="https://bugs.webkit.org/show_bug.cgi?id=158900">bug 158900</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281623&action=diff" name="attach_281623" title="Patch">attachment 281623</a> <a href="attachment.cgi?id=281623&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281623&action=review">https://bugs.webkit.org/attachment.cgi?id=281623&action=review</a>
<span class="quote">> Source/WebCore/style/AttributeChangeInvalidation.cpp:38
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, bool isHTML, const QualifiedName& attributeName)</span >
Can shadowRoot be const?
<span class="quote">> Source/WebCore/style/ClassChangeInvalidation.cpp:88
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, AtomicStringImpl* changedClass)</span >
const shadowRoot?
<span class="quote">> Source/WebCore/style/IdChangeInvalidation.cpp:44
> +static bool mayBeAffectedByHostStyle(ShadowRoot& shadowRoot, const AtomicString& changedId)
> +{
> + auto& shadowRuleSets = shadowRoot.styleResolver().ruleSets();
> + if (shadowRuleSets.authorStyle()->hostPseudoClassRules().isEmpty())
> + return false;
> +
> + return shadowRuleSets.features().idsInRules.contains(changedId.impl());
> +}</span >
Can this function that's almost repeated 3 times be shared?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>