[Webkit-unassigned] [Bug 158902] js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 18 23:15:18 PDT 2016


--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 281611
  --> https://bugs.webkit.org/attachment.cgi?id=281611

View in context: https://bugs.webkit.org/attachment.cgi?id=281611&action=review

> Source/WebCore/ChangeLog:8
> +        Make sure that the ResourceTiming runtime flag is turned off between tests.

As Alex noted, this presumably happens with other runtime enabled features too.

> Source/WebCore/testing/Internals.cpp:418
> +    RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(false);

My thinking was that we need to record original values before changing them. A hardcoded false could get out of sync with a changed default.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160619/793a08b5/attachment.html>

More information about the webkit-unassigned mailing list