<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158902#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158902">bug 158902</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281611&action=diff" name="attach_281611" title="Patch">attachment 281611</a> <a href="attachment.cgi?id=281611&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281611&action=review">https://bugs.webkit.org/attachment.cgi?id=281611&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + Make sure that the ResourceTiming runtime flag is turned off between tests.</span >
As Alex noted, this presumably happens with other runtime enabled features too.
<span class="quote">> Source/WebCore/testing/Internals.cpp:418
> + RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(false);</span >
My thinking was that we need to record original values before changing them. A hardcoded false could get out of sync with a changed default.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>