[Webkit-unassigned] [Bug 158873] WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158873

--- Comment #3 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 281562
  --> https://bugs.webkit.org/attachment.cgi?id=281562
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281562&action=review

> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:59
> +    if (dictionary.getWithUndefinedOrNullCheck("sdpMLineIndex", sdpMLineIndexString)) {
> +        if (!sdpMLineIndexString.isNull()) {

I think you can join the 2 ifs in just one with an and condition. Also check if getWithUndefinedOrNullCheck returns false if undefined or null, maybe we do not need the second condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160617/0d5df358/attachment-0001.html>