<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly"
href="https://bugs.webkit.org/show_bug.cgi?id=158873#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly"
href="https://bugs.webkit.org/show_bug.cgi?id=158873">bug 158873</a>
from <span class="vcard"><a class="email" href="mailto:alex@igalia.com" title="Alejandro G. Castro <alex@igalia.com>"> <span class="fn">Alejandro G. Castro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281562&action=diff" name="attach_281562" title="Proposed patch">attachment 281562</a> <a href="attachment.cgi?id=281562&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281562&action=review">https://bugs.webkit.org/attachment.cgi?id=281562&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:59
> + if (dictionary.getWithUndefinedOrNullCheck("sdpMLineIndex", sdpMLineIndexString)) {
> + if (!sdpMLineIndexString.isNull()) {</span >
I think you can join the 2 ifs in just one with an and condition. Also check if getWithUndefinedOrNullCheck returns false if undefined or null, maybe we do not need the second condition.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>