[Webkit-unassigned] [Bug 158798] Moved key function of JSC::StringSourceProvider to JSC library.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 04:52:24 PDT 2016


--- Comment #6 from Konstantin Tokarev <annulen at yandex.ru> ---
Intention of this patch was to move vtable of JSC::StringSourceProvider into JSC library/framework, as opposed to generation of vtable in user code as it's done now. Itanium C++ ABI says:

"The virtual table for a class is emitted in the same object containing the definition of its key function, i.e. the first non-pure virtual function that is not inline at the point of class definition. If there is no key function, it is emitted everywhere used."

So, making first virtual function (in this case, dtor) non-inline should move vtable definition into the library (and I believe this is the good thing on its own). Patch in its current form works as expected on Linux and Windows.

I'll investigate it further.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160616/3aefa532/attachment.html>

More information about the webkit-unassigned mailing list