<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Moved key function of JSC::StringSourceProvider to JSC library."
href="https://bugs.webkit.org/show_bug.cgi?id=158798#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Moved key function of JSC::StringSourceProvider to JSC library."
href="https://bugs.webkit.org/show_bug.cgi?id=158798">bug 158798</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>Intention of this patch was to move vtable of JSC::StringSourceProvider into JSC library/framework, as opposed to generation of vtable in user code as it's done now. Itanium C++ ABI says:
"The virtual table for a class is emitted in the same object containing the definition of its key function, i.e. the first non-pure virtual function that is not inline at the point of class definition. If there is no key function, it is emitted everywhere used."
So, making first virtual function (in this case, dtor) non-inline should move vtable definition into the library (and I believe this is the good thing on its own). Patch in its current form works as expected on Linux and Windows.
I'll investigate it further.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>