[Webkit-unassigned] [Bug 154444] [ThreadedCompositor] Opening the inspector in a window causes a crash.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154444

--- Comment #14 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 281169
  --> https://bugs.webkit.org/attachment.cgi?id=281169
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281169&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:66
> +        m_scene->setActive(handle);

!!handle converts better (i.e. cleaner) to a boolean value.

> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:69
> +        ensureGLContext();
> +        updateViewport();

It's not clear from the change log -- are these calls required in case of handle being null?

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:202
> +    scheduleLayerFlush();

Why cancel and then re-schedule the layer flush? Just re-scheduling should be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160614/ea7d4d5f/attachment-0001.html>