<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Opening the inspector in a window causes a crash."
href="https://bugs.webkit.org/show_bug.cgi?id=154444#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Opening the inspector in a window causes a crash."
href="https://bugs.webkit.org/show_bug.cgi?id=154444">bug 154444</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281169&action=diff" name="attach_281169" title="Updated patch">attachment 281169</a> <a href="attachment.cgi?id=281169&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281169&action=review">https://bugs.webkit.org/attachment.cgi?id=281169&action=review</a>
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:66
> + m_scene->setActive(handle);</span >
!!handle converts better (i.e. cleaner) to a boolean value.
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:69
> + ensureGLContext();
> + updateViewport();</span >
It's not clear from the change log -- are these calls required in case of handle being null?
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:202
> + scheduleLayerFlush();</span >
Why cancel and then re-schedule the layer flush? Just re-scheduling should be enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>