[Webkit-unassigned] [Bug 158634] AX: Form label text should be exposed as static text if it contains only static text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158634

--- Comment #6 from Doug Russell <d_russell at apple.com> ---
Comment on attachment 281045
  --> https://bugs.webkit.org/attachment.cgi?id=281045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281045&action=review

>>>> Source/WebCore/accessibility/AccessibilityLabel.cpp:92
>>>> +    return WebCore::containsOnlyStaticText(m_children);
>>> 
>>> This WebCore:: prefix is probably unnecessary
>> 
>> You need it to disambiguate from AccessibilityLabel::containsOnlyStaticText() (the compiler gets huffy without it)
> 
> Might be better named
> 
> objectsContainOnlyStaticText or elementsContainOnlyStaticText
> 
> Since children is no longer accurate, the method being static rattan than an instance

The argument type is const AccessibilityObject::AccessibilityChildrenVector& so I think children is fair to use. I'll rename is childrenContainOnlyStaticText.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/87c04c99/attachment.html>