<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634">bug 158634</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281045&action=diff" name="attach_281045" title="Patch">attachment 281045</a> <a href="attachment.cgi?id=281045&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281045&action=review">https://bugs.webkit.org/attachment.cgi?id=281045&action=review</a>
<span class="quote">>>>> Source/WebCore/accessibility/AccessibilityLabel.cpp:92
>>>> + return WebCore::containsOnlyStaticText(m_children);
>>>
>>> This WebCore:: prefix is probably unnecessary
>>
>> You need it to disambiguate from AccessibilityLabel::containsOnlyStaticText() (the compiler gets huffy without it)
>
> Might be better named
>
> objectsContainOnlyStaticText or elementsContainOnlyStaticText
>
> Since children is no longer accurate, the method being static rattan than an instance</span >
The argument type is const AccessibilityObject::AccessibilityChildrenVector& so I think children is fair to use. I'll rename is childrenContainOnlyStaticText.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>