[Webkit-unassigned] [Bug 158617] New: REGRESSION (r200320): [GTK] resource-timing tests are broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158617

            Bug ID: 158617
           Summary: REGRESSION (r200320): [GTK] resource-timing tests are
                    broken
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: achristensen at apple.com, bugs-noreply at webkitgtk.org,
                    lforschler at apple.com, yoav at yoav.ws
            Blocks: 61138

Revision r200320 <http://trac.webkit.org/changeset/200320> changed the resource timing feature from a build-time to a run-time feature.

Since then, then resource timing tests have been broken on the GTK+ port.

I have tried to manually enable the feature on a test to check if it will work:

--- a/LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html
+++ b/LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html
@@ -31,6 +31,8 @@ function setup_iframe() {
     iframeBody.appendChild(move_to_child);
 }
 function onload_test() {
+    if (window.internals)
+        internals.setResourceTimingSupport(true);
     var context = new PerformanceContext(iframe.contentWindow.performance);
     var entries = context.getEntries();


And it started to work back.



Now I wonder:

 * Why this is only happening on the GTK+ port? The EFL port has all resource-timing tests skipped, but not the Mac one.
 * How are this tests working on the Mac port?
 * What should we do? Patch all tests to manually enable this feature?


$ find LayoutTests/ -type f -name TestExpectations|xargs grep resource-timing
LayoutTests/platform/efl/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/efl/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Google/resource-timing [ Skip ]
LayoutTests/platform/win/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/127733 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html [ Failure Pass ]
LayoutTests/platform/gtk/TestExpectations:Bug(GTK) http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html [ Failure ]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/cb859cc3/attachment.html>