<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (r200320): [GTK] resource-timing tests are broken"
href="https://bugs.webkit.org/show_bug.cgi?id=158617">158617</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>REGRESSION (r200320): [GTK] resource-timing tests are broken
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>clopez@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>achristensen@apple.com, bugs-noreply@webkitgtk.org, lforschler@apple.com, yoav@yoav.ws
</td>
</tr>
<tr>
<th>Blocks</th>
<td>61138
</td>
</tr></table>
<p>
<div>
<pre>Revision r200320 <<a href="http://trac.webkit.org/changeset/200320">http://trac.webkit.org/changeset/200320</a>> changed the resource timing feature from a build-time to a run-time feature.
Since then, then resource timing tests have been broken on the GTK+ port.
I have tried to manually enable the feature on a test to check if it will work:
--- a/LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html
+++ b/LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html
@@ -31,6 +31,8 @@ function setup_iframe() {
iframeBody.appendChild(move_to_child);
}
function onload_test() {
+ if (window.internals)
+ internals.setResourceTimingSupport(true);
var context = new PerformanceContext(iframe.contentWindow.performance);
var entries = context.getEntries();
And it started to work back.
Now I wonder:
* Why this is only happening on the GTK+ port? The EFL port has all resource-timing tests skipped, but not the Mac one.
* How are this tests working on the Mac port?
* What should we do? Patch all tests to manually enable this feature?
$ find LayoutTests/ -type f -name TestExpectations|xargs grep resource-timing
LayoutTests/platform/efl/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/efl/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Google/resource-timing [ Skip ]
LayoutTests/platform/win/TestExpectations:webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/127733 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html [ Failure Pass ]
LayoutTests/platform/gtk/TestExpectations:Bug(GTK) http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html [ Failure ]
LayoutTests/platform/gtk/TestExpectations:webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html [ Failure ]</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>