[Webkit-unassigned] [Bug 158466] Add event support for link preload.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158466

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280799|review?                     |review-
              Flags|                            |

--- Comment #38 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 280799
  --> https://bugs.webkit.org/attachment.cgi?id=280799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280799&action=review

> Source/WebCore/loader/LinkPreloadResourceClients.cpp:2
> + * Copyright 2016 The Chromium Authors. All rights reserved.

Did the chromium authors write this?  Is there a corresponding crbug?

> Source/WebCore/loader/LinkPreloadResourceClients.h:28
> +#ifndef LinkPreloadResourceClients_h
> +#define LinkPreloadResourceClients_h

#pragma once

> Source/WebCore/loader/LinkPreloadResourceClients.h:81
> +        return new LinkPreloadScriptResourceClient(loader, resource);

This is a memory leak.  There's no corresponding delete.  Instead of Optional, I think we should just use std::unique_ptr

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:1035
>  #if !PLATFORM(IOS)

I think we should consider making iOS loading work more like everything else.  Probably not in this patch, though.

> Source/WebCore/platform/network/ResourceRequestBase.h:152
> +    bool ignoreForRequestCounting() const { return m_ignoreForRequestCounting; }
> +    void setIgnoreForRequestCounting(bool ignoreForRequestCounting) { m_ignoreForRequestCounting = ignoreForRequestCounting; }

shouldIgnoreForeRequestCounting and setShouldIgnoreForRequestCounting might be better names.  Or maybe ignoreForRequestCount to match CachedResource.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/50cdb443/attachment.html>