[Webkit-unassigned] [Bug 158190] WebRTC: Imlement MediaEndpointPeerConnection::setLocalDescription()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158190

--- Comment #4 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #2)
> Comment on attachment 280724 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280724&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:161
> > +    RefPtr<MediaEndpointSessionConfiguration> configurationSnapshot = internalLocalDescription() ?
> > +        internalLocalDescription()->configuration()->clone() : MediaEndpointSessionConfiguration::create();
> 
> Nit: it may be worth putting internalLocalDescription() into a local instead
> of calling it twice.

Fixed.

> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:258
> > +    unsigned previousNumberOfMediaDescriptions = internalLocalDescription() ?
> > +        internalLocalDescription()->configuration()->mediaDescriptions().size() : 0;
> 
> Ditto.

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/547889f4/attachment.html>