<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Imlement MediaEndpointPeerConnection::setLocalDescription()"
href="https://bugs.webkit.org/show_bug.cgi?id=158190#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Imlement MediaEndpointPeerConnection::setLocalDescription()"
href="https://bugs.webkit.org/show_bug.cgi?id=158190">bug 158190</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158190#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=280724&action=diff" name="attach_280724" title="Proposed patch">attachment 280724</a> <a href="attachment.cgi?id=280724&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=280724&action=review">https://bugs.webkit.org/attachment.cgi?id=280724&action=review</a>
>
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:161
> > + RefPtr<MediaEndpointSessionConfiguration> configurationSnapshot = internalLocalDescription() ?
> > + internalLocalDescription()->configuration()->clone() : MediaEndpointSessionConfiguration::create();
>
> Nit: it may be worth putting internalLocalDescription() into a local instead
> of calling it twice.</span >
Fixed.
<span class="quote">> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:258
> > + unsigned previousNumberOfMediaDescriptions = internalLocalDescription() ?
> > + internalLocalDescription()->configuration()->mediaDescriptions().size() : 0;
>
> Ditto.</span >
Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>