[Webkit-unassigned] [Bug 158473] [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158473

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 280694 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280694&action=review
> 
> > Source/WebCore/platform/glib/FileSystemGlib.cpp:394
> > +    return g_file_copy(sourceFile.get(), destinationFile.get(), G_FILE_COPY_NONE, nullptr, nullptr, nullptr, nullptr);
> 
> Probably should use G_FILE_COPY_OVERWRITE instead of G_FILE_COPY_NONE?

I don't think so, this is a fallback for link, and link fails if destination exists. I think the posix implementation also fails if destination exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160607/70fda9fa/attachment-0001.html>