<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib"
href="https://bugs.webkit.org/show_bug.cgi?id=158473#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib"
href="https://bugs.webkit.org/show_bug.cgi?id=158473">bug 158473</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158473#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=280694&action=diff" name="attach_280694" title="Patch">attachment 280694</a> <a href="attachment.cgi?id=280694&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=280694&action=review">https://bugs.webkit.org/attachment.cgi?id=280694&action=review</a>
>
> > Source/WebCore/platform/glib/FileSystemGlib.cpp:394
> > + return g_file_copy(sourceFile.get(), destinationFile.get(), G_FILE_COPY_NONE, nullptr, nullptr, nullptr, nullptr);
>
> Probably should use G_FILE_COPY_OVERWRITE instead of G_FILE_COPY_NONE?</span >
I don't think so, this is a fallback for link, and link fails if destination exists. I think the posix implementation also fails if destination exists.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>