[Webkit-unassigned] [Bug 158473] [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158473

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 280689
  --> https://bugs.webkit.org/attachment.cgi?id=280689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280689&action=review

Informally reviewed. LGTM with a nit.

> Source/WebCore/platform/glib/FileSystemGlib.cpp:385
> +    if (!link(sourceFilename.get(), destinationFilename.get()))

In Windows the CreateHardLink() function could be used here instead of always copying the file (though it only works in NTFS, see: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363860(v=vs.85).aspx), so please add a TODO comment here to let developers working in Windows that they may want to add the relevant code in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160607/2938a03f/attachment.html>