<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib"
href="https://bugs.webkit.org/show_bug.cgi?id=158473#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement hardLinkOrCopyFile() in FileSystemGlib"
href="https://bugs.webkit.org/show_bug.cgi?id=158473">bug 158473</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez <aperez@igalia.com>"> <span class="fn">Adrian Perez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=280689&action=diff" name="attach_280689" title="Patch">attachment 280689</a> <a href="attachment.cgi?id=280689&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=280689&action=review">https://bugs.webkit.org/attachment.cgi?id=280689&action=review</a>
Informally reviewed. LGTM with a nit.
<span class="quote">> Source/WebCore/platform/glib/FileSystemGlib.cpp:385
> + if (!link(sourceFilename.get(), destinationFilename.get()))</span >
In Windows the CreateHardLink() function could be used here instead of always copying the file (though it only works in NTFS, see: <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/aa363860(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/windows/desktop/aa363860(v=vs.85).aspx</a>), so please add a TODO comment here to let developers working in Windows that they may want to add the relevant code in the future.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>