[Webkit-unassigned] [Bug 158191] WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 02:52:31 PDT 2016


--- Comment #9 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
Comment on attachment 280309
  --> https://bugs.webkit.org/attachment.cgi?id=280309
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280309&action=review

>> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:135
>> +    RtpSenderVector senders = RtpSenderVector(m_client->getSenders());
> I don’t think we need to state the class name twice. Default behavior when receiving a const& is to make a copy, in fact, this should work:
>     auto senders = m_client->getSenders();
> But we need a comment explaining why we need a copy rather than using the reference. The copy is expensive.

The content of this function is replaced in https://bugs.webkit.org/show_bug.cgi?id=158203.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160603/a72ddbde/attachment.html>

More information about the webkit-unassigned mailing list