<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver"
href="https://bugs.webkit.org/show_bug.cgi?id=158191#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver"
href="https://bugs.webkit.org/show_bug.cgi?id=158191">bug 158191</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=280309&action=diff" name="attach_280309" title="Updated patch">attachment 280309</a> <a href="attachment.cgi?id=280309&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=280309&action=review">https://bugs.webkit.org/attachment.cgi?id=280309&action=review</a>
<span class="quote">>> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:135
>> + RtpSenderVector senders = RtpSenderVector(m_client->getSenders());
>
> I don’t think we need to state the class name twice. Default behavior when receiving a const& is to make a copy, in fact, this should work:
>
> auto senders = m_client->getSenders();
>
> But we need a comment explaining why we need a copy rather than using the reference. The copy is expensive.</span >
The content of this function is replaced in <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update MediaEndpointPeerConnection::createOffer() to use the transceiver set"
href="show_bug.cgi?id=158203">https://bugs.webkit.org/show_bug.cgi?id=158203</a>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>