[Webkit-unassigned] [Bug 158206] [jsc][mips] implement absDouble()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 10:41:23 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158206

--- Comment #5 from Guillaume Emont <guijemont at igalia.com> ---
(In reply to comment #4)
> It is not complete, please refer to my commit in QtWebKit:
> http://code.qt.io/cgit/qt/qtwebkit.git/commit/
> ?id=b6ddb5fe5d3f2223d524e45bf5cdbdde0e5b241f

Indeed, I did not catch that supportsFloatingPointAbs(), or see that you had made that change in qtwebkit. I think we need to check for WTF_MIPS_ISA_AT_LEAST(2) as well, since abs.d is only available from mips 2 on.
> 
> Also, please put absd() implementation between sqrtd and movd in
> MacroAssemblerMIPS.h to keep the opcodes ordered.
It looks overall not very well ordered and I tried to put it in alphabetical order, but I'm fine with doing that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160602/25c6e0f2/attachment.html>


More information about the webkit-unassigned mailing list