<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] implement absDouble()"
href="https://bugs.webkit.org/show_bug.cgi?id=158206#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] implement absDouble()"
href="https://bugs.webkit.org/show_bug.cgi?id=158206">bug 158206</a>
from <span class="vcard"><a class="email" href="mailto:guijemont@igalia.com" title="Guillaume Emont <guijemont@igalia.com>"> <span class="fn">Guillaume Emont</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158206#c4">comment #4</a>)
<span class="quote">> It is not complete, please refer to my commit in QtWebKit:
> <a href="http://code.qt.io/cgit/qt/qtwebkit.git/commit/">http://code.qt.io/cgit/qt/qtwebkit.git/commit/</a>
> ?id=b6ddb5fe5d3f2223d524e45bf5cdbdde0e5b241f</span >
Indeed, I did not catch that supportsFloatingPointAbs(), or see that you had made that change in qtwebkit. I think we need to check for WTF_MIPS_ISA_AT_LEAST(2) as well, since abs.d is only available from mips 2 on.
<span class="quote">>
> Also, please put absd() implementation between sqrtd and movd in
> MacroAssemblerMIPS.h to keep the opcodes ordered.</span >
It looks overall not very well ordered and I tried to put it in alphabetical order, but I'm fine with doing that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>