[Webkit-unassigned] [Bug 158243] Precache primary font in a secondary thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 09:55:21 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158243

--- Comment #15 from Brady Eidson <beidson at apple.com> ---
(In reply to comment #14)
> (In reply to comment #13)
> > I believe this patch has a number of thread safety issues.
> 
> Namely the chunk at the end of FontCacheCoreText.
> 
> At the very least there's one string thread safety issue by passing the
> family to the work queue not as an isolatedCopy.

Maybe not, since the Task itself is deleted on the main thread, and an isolated copy is made in work queue.

But it's not at all obvious at a glance (hence my comment).

Anyways, I'm doing a pass over all RunLoop::dispatch users right now which is why I noticed this - I'll clean it up a bit like Chris suggested after landing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160601/02d876db/attachment.html>


More information about the webkit-unassigned mailing list