<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Precache primary font in a secondary thread"
href="https://bugs.webkit.org/show_bug.cgi?id=158243#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Precache primary font in a secondary thread"
href="https://bugs.webkit.org/show_bug.cgi?id=158243">bug 158243</a>
from <span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158243#c14">comment #14</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=158243#c13">comment #13</a>)
> > I believe this patch has a number of thread safety issues.
>
> Namely the chunk at the end of FontCacheCoreText.
>
> At the very least there's one string thread safety issue by passing the
> family to the work queue not as an isolatedCopy.</span >
Maybe not, since the Task itself is deleted on the main thread, and an isolated copy is made in work queue.
But it's not at all obvious at a glance (hence my comment).
Anyways, I'm doing a pass over all RunLoop::dispatch users right now which is why I noticed this - I'll clean it up a bit like Chris suggested after landing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>