[Webkit-unassigned] [Bug 157973] PlatformDisplay crash when calling egl_terminate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157973

--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #7)
> Only PlatformDisplay::sharedDisplay() should ever live during the program
> lifetime, so this method would only be called only once as well. Asserting
> !m_eglDisplayInitialized at the beginning here would be helpful in that
> regard.

Are you saying that this class is intended to be a singleton? If so, then it should use our normal singleton naming convention (PlatformDisplay::singleton rather than PlatformDisplay::sharedDisplay), and should have nothing in its destructor (as it would never make sense to call egl_terminate there if it's always scheduled by atexit), and terminateEGLDisplay should be called on the this pointer rather than sharedDisplay for readability. If it's not supposed to be a singleton, then the assert you suggested would be inappropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160601/9783f8c4/attachment.html>