[Webkit-unassigned] [Bug 157899] [GTK] Provide frame-related load signals in WebKitWebView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 03:45:44 PDT 2016


--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 279764
  --> https://bugs.webkit.org/attachment.cgi?id=279764
proposed patch IV

View in context: https://bugs.webkit.org/attachment.cgi?id=279764&action=review

LGTM, Carlos?

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:84
> +    g_assert(frame_uri && *frame_uri);

I would use a stronger assertion here if possible; it should only be called once, and the URI should end with unknown-file.html, right?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160601/8a21ac9e/attachment.html>

More information about the webkit-unassigned mailing list