<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Provide frame-related load signals in WebKitWebView"
href="https://bugs.webkit.org/show_bug.cgi?id=157899#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Provide frame-related load signals in WebKitWebView"
href="https://bugs.webkit.org/show_bug.cgi?id=157899">bug 157899</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279764&action=diff" name="attach_279764" title="proposed patch IV">attachment 279764</a> <a href="attachment.cgi?id=279764&action=edit" title="proposed patch IV">[details]</a></span>
proposed patch IV
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279764&action=review">https://bugs.webkit.org/attachment.cgi?id=279764&action=review</a>
LGTM, Carlos?
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:84
> + g_assert(frame_uri && *frame_uri);</span >
I would use a stronger assertion here if possible; it should only be called once, and the URI should end with unknown-file.html, right?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>